Fixed After and Instead of trigger issues on table #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. If an After trigger exists on table, it is skipped after instead of trigger is fired on same table in Babelfish. 2. Query execution and After trigger is skipped on table in babelfish when it has a disabled Instead of Trigger Task: BABEL-4672 and BABEL-4801 Signed-off-by: Deepakshi Mittal <[email protected]>
Signed-off-by: Deepakshi Mittal <[email protected]>
1 task
Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-4672-pg14
branch
from
9e56d53 to
8963fcc
Compare
forestkeeper
approved these changes
Apr 25, 2024
forestkeeper
merged commit 81c59da
into
babelfish-for-postgresql:BABEL_2_X_DEV
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an After trigger exists on table, it is skipped after instead of trigger is fired on same table in Babelfish.
Query execution and After trigger is skipped on table in babelfish when it has a disabled Instead of Trigger
Task: BABEL-4672 and BABEL-4801
Description
This PR also contain test case fix for inserted and deleted transition table
PR: #2530
Previous PRs:
Pg16 Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#320
Pg Extensions PR: #2390
Pg15 Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#328
Pg 15 Extensions PR: #2425
Issues Resolved
[List any issues this PR will resolve]
Test Scenarios Covered
Test Scenarios Covered
Instead of IUD TRIGGER with After IUD TRIGGER on table
Check List
-[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.